Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated include #400

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove deprecated include #400

merged 1 commit into from
Jul 20, 2022

Conversation

chapulina
Copy link
Contributor

Follow up to

Summary

Just a left-over that I found.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll as a code owner July 20, 2022 20:38
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 20, 2022
@mjcarroll mjcarroll enabled auto-merge (squash) July 20, 2022 20:41
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #400 (0b00c60) into main (d795593) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b00c60 differs from pull request most recent head 73e072f. Consider uploading reports for the commit 73e072f to get more accurate results

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files          85       85           
  Lines       10776    10776           
=======================================
  Hits         8386     8386           
  Misses       2390     2390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d795593...73e072f. Read the comment docs.

@mjcarroll mjcarroll merged commit 4136c0a into main Jul 20, 2022
@mjcarroll mjcarroll deleted the chapulina/5/depre branch July 20, 2022 21:03
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants