Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IGN_DESIGNATION to GZ_DESIGNATION #399

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Change IGN_DESIGNATION to GZ_DESIGNATION #399

merged 1 commit into from
Jul 23, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 20, 2022

Signed-off-by: Nate Koenig [email protected]

I ran find . -name "*" -exec -i 's/IGN_DESIGNATION/GZ_DESIGNATION/g' {} \; in order to make this repository compliant with gazebosim/gz-cmake#282

@nkoenig nkoenig requested a review from mjcarroll as a code owner July 20, 2022 15:04
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #399 (57325d4) into ign-common3 (983c5e9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-common3     #399   +/-   ##
============================================
  Coverage        76.63%   76.63%           
============================================
  Files               73       73           
  Lines            10425    10425           
============================================
  Hits              7989     7989           
  Misses            2436     2436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983c5e9...57325d4. Read the comment docs.

@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels Jul 20, 2022
chapulina
chapulina approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge this until gazebosim/gz-cmake#282 is merged and released.

@scpeters scpeters mentioned this pull request Jul 22, 2022
Merged
7 tasks
@chapulina chapulina merged commit 88bde3d into ign-common3 Jul 23, 2022
@chapulina chapulina deleted the gz-designation branch July 23, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @chapulina