-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lunar coordinate transformations #377
Conversation
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document new method
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 77.82% 77.85% +0.03%
==========================================
Files 85 85
Lines 10776 10783 +7
==========================================
+ Hits 8386 8395 +9
+ Misses 2390 2388 -2
Continue to review full report at Codecov.
|
Signed-off-by: Aditya <[email protected]>
de85ea3
to
5bb4c5b
Compare
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the SetUnknownDEM
and UknownDEM
functions needed anymore? I believe with your gz-math and sdformat updates, these methods aren't necessary anymore and can be removed
Also, can you update the comments for both the GeoReference*
functions, removing WGS84
?
gz-common/geospatial/include/gz/common/geospatial/Dem.hh
Lines 85 to 86 in ffb8607
/// \brief Get the georeferenced coordinates (lat, long) of the terrain's | |
/// origin in WGS84. |
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Done 97b1c6d |
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! One minor comment
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as well, thanks @jennuine for taking the lift on reviews here!
Signed-off-by: Aditya <[email protected]>
* Expose method to set spherical coordinates, added transformation logic for moon and custom surfaces. Signed-off-by: Aditya <[email protected]>
🎉 New feature
Summary
This PR adds a method to accept the spherical coordinates from the world, and calculate DEM sizes accordingly.
Logic is added to
GeoReference()
method to perform appropriate transformation for lunar surface.Extending the same logic as lunar coordinate transformations, we can support transformations for custom surfaces as well.
Test it
Added a simple test to
Dem_TEST.cc
. The GeoReference method is private currently, and I'm not sure how to verify those coordinate transformations externally.TODO :
isNonEarthDem
flag should be renamed toisUnknownDem
or something, since we do support lunar dems now. Open to suggestions !Depends on :
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸