Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Macro Migration : gz-common #366

Merged
merged 14 commits into from
Jun 17, 2022
Merged

ign -> gz Macro Migration : gz-common #366

merged 14 commits into from
Jun 17, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from mjcarroll as a code owner June 6, 2022 21:48
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
@chapulina chapulina self-requested a review June 6, 2022 22:43
@methylDragon methylDragon force-pushed the macro_migration branch 2 times, most recently from 5ef36e1 to 57c96f5 Compare June 7, 2022 01:42
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
@chapulina chapulina changed the base branch from main to env_var_migration June 7, 2022 02:03
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
Migration.md Show resolved Hide resolved
include/ignition/common/EnumIface.hh Outdated Show resolved Hide resolved
include/ignition/common/detail/SpecializedPlugin.hh Outdated Show resolved Hide resolved
profiler/src/CMakeLists.txt Outdated Show resolved Hide resolved
profiler/src/CMakeLists.txt Show resolved Hide resolved
@methylDragon methylDragon force-pushed the macro_migration branch 3 times, most recently from 8bd54a0 to 2049236 Compare June 7, 2022 18:46
Base automatically changed from env_var_migration to main June 8, 2022 04:07
@methylDragon
Ticktock environment variables
af35df9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Update tick-tocking logic
574e6b6 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate macros
2a7cb78 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Update migration guide to mention header-dependent macros
4edd119 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fold in some unrelated comment changes
4886d4f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix variadic macro args
9346d2d 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Revert IGNITION_UNITTEST_SPECIALIZED_PLUGIN_ACCESS
2aacd1e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Ticktock IGN_PROFILER_REMOTERY
5dded16 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix warning punctuation
b4a2269 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fold in material hard-tock
a9517c0 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #366 (a9517c0) into main (c97c92e) will increase coverage by 0.90%.
The diff coverage is 85.41%.

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   77.88%   78.79%   +0.90%     
==========================================
  Files          84       81       -3     
  Lines       10728    10546     -182     
==========================================
- Hits         8356     8310      -46     
+ Misses       2372     2236     -136
Impacted Files Coverage Δ
graphics/include/gz/common/Image.hh 97.05% <ø> (ø)
graphics/include/gz/common/NodeTransform.hh 100.00% <ø> (ø)
graphics/include/gz/common/SVGLoader.hh 100.00% <ø> (ø)
graphics/src/BVHLoader.cc 0.00% <0.00%> (ø)
graphics/src/NodeTransform.cc 59.09% <0.00%> (ø)
graphics/src/OBJLoader.cc 93.10% <ø> (ø)
graphics/src/tiny_obj_loader.h 61.81% <ø> (ø)
include/gz/common/Battery.hh 100.00% <ø> (ø)
include/gz/common/EnumIface.hh 100.00% <ø> (ø)
include/gz/common/Filesystem.hh 100.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c97c92e...a9517c0. Read the comment docs.

@methylDragon methylDragon merged commit c7b0636 into main Jun 17, 2022
@methylDragon methylDragon deleted the macro_migration branch June 17, 2022 23:39
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
@methylDragon @chapulina @luca-della-vedova
ign -> gz Macro Migration : gz-common (#366)
72ee00b 
Co-authored-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina