Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Timer_TEST more robust #343

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Make Timer_TEST more robust #343

merged 3 commits into from
Apr 15, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

It's been a bit flaky, some CI machines are "too" fast.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from methylDragon April 14, 2022 22:24
@chapulina chapulina requested a review from mjcarroll as a code owner April 14, 2022 22:24
@chapulina chapulina added the tests Broken or missing tests / testing infra label Apr 14, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #343 (eb51f8f) into main (0eafe48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           1        1           
  Lines          48       48           
=======================================
  Hits           44       44           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eafe48...eb51f8f. Read the comment docs.

@mjcarroll
Copy link
Contributor

Ha, did the same thing over here, so good with me: 0c3e647

src/Timer_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) April 15, 2022 15:30
@chapulina chapulina merged commit 153ce13 into main Apr 15, 2022
@chapulina chapulina deleted the chapulina/5/timer_test branch April 15, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants