Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Drop all test main functions from gtest files #322

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

All of our tests link gtest_main, so including main functions is redundant.

Signed-off-by: Michael Carroll [email protected]

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #322 (8ecc9d6) into main (c2055f7) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   77.12%   77.22%   +0.09%     
==========================================
  Files          76       84       +8     
  Lines       10528    10657     +129     
==========================================
+ Hits         8120     8230     +110     
- Misses       2408     2427      +19     
Impacted Files Coverage Δ
.../include/ignition/common/testing/BazelTestPaths.hh 0.00% <0.00%> (ø)
testing/src/BazelTestPaths.cc 0.00% <0.00%> (ø)
.../include/ignition/common/testing/CMakeTestPaths.hh 100.00% <0.00%> (ø)
...e/ignition/common/testing/detail/AutoLogFixture.hh 100.00% <0.00%> (ø)
testing/src/Utils.cc 80.00% <0.00%> (ø)
...sting/include/ignition/common/testing/TestPaths.hh 100.00% <0.00%> (ø)
testing/src/TestPaths.cc 78.37% <0.00%> (ø)
testing/src/CMakeTestPaths.cc 100.00% <0.00%> (ø)
src/PluginLoader.cc 97.67% <0.00%> (+1.55%) ⬆️
src/TempDirectory.cc 81.48% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2055f7...8ecc9d6. Read the comment docs.

@mjcarroll mjcarroll self-assigned this Mar 15, 2022
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll changed the base branch from use_common_testing to main March 25, 2022 18:00
@mjcarroll mjcarroll changed the title Drop all test main functions 🧹 Drop all test main functions from gtest files Mar 29, 2022
@mjcarroll mjcarroll merged commit c06cbb6 into main Mar 29, 2022
@mjcarroll mjcarroll deleted the drop_all_main branch March 29, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants