Miscellaneous cleanup of Events API #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 76.74% 76.74% -0.01%
==========================================
Files 75 75
Lines 10325 10323 -2
==========================================
- Hits 7924 7922 -2
Misses 2401 2401
Continue to review full report at Codecov.
|
|
Test failures are flakes:
|
|
I can't reproduce the |
mjcarroll
force-pushed
the
implptr_av
branch
2 times, most recently
from
b3d3ce2 to
01fbff4
Compare
mjcarroll
force-pushed
the
events_cleanup
branch
from
3de294c to
dbbbd59
Compare
mjcarroll
force-pushed
the
events_cleanup
branch
2 times, most recently
from
74edd4f to
85a3198
Compare
iche033
approved these changes
Feb 16, 2022
According to clang-tidy, there is no value in having them there. https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
events_cleanup
branch
from
85a3198 to
21f176c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with the Events API:
const primitivearguments to functions. https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.htmlSetXXXfunction asconstwhere we mutated internal data, breaking const-correctness.These are split in two commits for easier review.