Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move performance test to examples #294

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

This performance test flooded the console during CI without adding much value.

This was initially incorporated to prove out worst-case latency when adding locking mechanisms to the console log. Since it doesn't actually make any assertions about behavior or performance, I believe that it makes more sense to live as an example.

The example will generate a CSV file that can be visualized as a histogram to show console logging latency with a variable number of threads.

Alternative to #293

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Jan 24, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #294 (795b593) into ign-common4 (ddeab2a) will not change coverage.
The diff coverage is n/a.

❗ Current head 795b593 differs from pull request most recent head 611c403. Consider uploading reports for the commit 611c403 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #294   +/-   ##
============================================
  Coverage        77.02%   77.02%           
============================================
  Files               76       76           
  Lines            10727    10727           
============================================
  Hits              8262     8262           
  Misses            2465     2465           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddeab2a...611c403. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@mjcarroll
Copy link
Contributor Author

Failing test of focal action is another somewhat-flaky performance test

@scpeters
Copy link
Member

Failing test of focal action is another somewhat-flaky performance test

restarted

@mjcarroll mjcarroll merged commit d5261a8 into ign-common4 Jan 25, 2022
@mjcarroll mjcarroll deleted the logging_perf_to_example branch January 25, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants