Fixed crash when a Collada file has an empty normal vector

[ahcorde]

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

If a collada file has defined normals but these are empty, then Ignition will crash. This should fix this crash

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #280 (05e6005) into ign-common4 (98b070d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-common4     #280   +/-   ##
============================================
  Coverage        77.01%   77.02%           
============================================
  Files               76       76           
  Lines            10725    10727    +2     
============================================
+ Hits              8260     8262    +2     
  Misses            2465     2465           

Impacted Files	Coverage Δ
graphics/src/ColladaLoader.cc	85.20% <100.00%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b070d...05e6005. Read the comment docs.

[chapulina]

That looks good to me. I'm wondering if we should also check that inputRemappedNormalIndex is in norms on this line below, to be safe.

subMesh->AddNormal(norms[inputRemappedNormalIndex]);

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1