Fixed macos symbol in common::profiler

[ahcorde]

Signed-off-by: Alejandro Hernández [email protected]

🦟 Bug fix

Summary

While I was testing the ign-gazebo python interface on macos I noticed that some symbols are missing. This should fix it.

There are some other which are not included, for example: RMT_USE_D3D11 or RMT_USE_OPENGL. Should we need to remove these ones or add the target_compile_definitions?

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #262 (b81e1f6) into ign-common3 (df11d6e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-common3     #262   +/-   ##
============================================
  Coverage        76.55%   76.55%           
============================================
  Files               73       73           
  Lines            10386    10386           
============================================
  Hits              7951     7951           
  Misses            2435     2435           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df11d6e...b81e1f6. Read the comment docs.

[mjcarroll]

There are some other which are not included, for example: RMT_USE_D3D11 or RMT_USE_OPENGL. Should we need to remove these ones or add the target_compile_definitions?

I didn't expose these because I didn't want to give the impression that they worked or were supported. We only needed CPU tracing as far as I remember when we first added the profiler.

[ahcorde]

There are some other which are not included, for example: RMT_USE_D3D11 or RMT_USE_OPENGL. Should we need to remove these ones or add the target_compile_definitions?

I didn't expose these because I didn't want to give the impression that they worked or were supported. We only needed CPU tracing as far as I remember when we first added the profiler.

maybe it's a good idea to remove them ? I can create another PR for that.

This one is required by macos

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1