Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tension for common5 #260

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Update tension for common5 #260

merged 1 commit into from
Oct 15, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 15, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Addresses the todo items from #256, by remove the extra functions that were added to avoid ABI problems.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from mjcarroll as a code owner October 15, 2021 15:26
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #260 (0e97897) into main (c5da532) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   77.05%   77.04%   -0.02%     
==========================================
  Files          75       75              
  Lines       10665    10658       -7     
==========================================
- Hits         8218     8211       -7     
  Misses       2447     2447              
Impacted Files Coverage Δ
graphics/src/Animation.cc 95.58% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5da532...0e97897. Read the comment docs.

@mjcarroll mjcarroll enabled auto-merge (squash) October 15, 2021 15:57
@mjcarroll mjcarroll merged commit 92abc29 into main Oct 15, 2021
@mjcarroll mjcarroll deleted the tension_common5_update branch October 15, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants