Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy constructor #224

Merged
merged 7 commits into from
Jun 9, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 9, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added Copy constructor to KeyEvent. Required by this PR gazebosim/gz-gui#224

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added enhancement New feature or request 🏰 citadel Ignition Citadel labels Jun 9, 2021
@ahcorde ahcorde requested a review from mjcarroll June 9, 2021 10:46
@ahcorde ahcorde self-assigned this Jun 9, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #224 (2ae2e5f) into ign-common3 (153f320) will increase coverage by 0.03%.
The diff coverage is 94.44%.

❗ Current head 2ae2e5f differs from pull request most recent head 466bbc3. Consider uploading reports for the commit 466bbc3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-common3     #224      +/-   ##
===============================================
+ Coverage        76.50%   76.53%   +0.03%     
===============================================
  Files               73       73              
  Lines            10361    10379      +18     
===============================================
+ Hits              7927     7944      +17     
- Misses            2434     2435       +1     
Impacted Files Coverage Δ
events/src/KeyEvent.cc 98.11% <94.44%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153f320...466bbc3. Read the comment docs.

@ahcorde ahcorde requested a review from mjcarroll June 9, 2021 14:41
@mjcarroll mjcarroll enabled auto-merge (squash) June 9, 2021 15:11
@mjcarroll mjcarroll merged commit c6bddd8 into ign-common3 Jun 9, 2021
@mjcarroll mjcarroll deleted the ahcorde/keyevent/copyconstructor branch June 9, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants