Fix join paths again #215
Merged
Fix join paths again #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not altered Signed-off-by: Nate Koenig <[email protected]>
mjcarroll
approved these changes
May 6, 2021
|
LGTM, but let's make sure that windows turns over green. |
Merged
Merged
added 3 commits
May 10, 2021 08:33
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
PR #209 broke a different part of fuel-tools, this time in ModelIdentifier. Strings with
https://serverwould becomehttps:/server. Note the missing second slash. This is an invalid URI.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge