Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.12.0 release #195

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Prepare for 3.12.0 release #195

merged 1 commit into from
Apr 6, 2021

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Apr 6, 2021

Signed-off-by: Michael Carroll [email protected]

🎈 Release

Preparation for <3.12.0>release.

Comparison to <3.11.1>: ignition-common3_3.11.1...ign-common3

Needed by gazebosim/gz-launch#97

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Apr 6, 2021
@mjcarroll mjcarroll requested review from iche033 and nkoenig April 6, 2021 18:18
@mjcarroll
Copy link
Contributor Author

Actually, I need to expand the changelog for this, give me a few minutes.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #195 (886bc6e) into ign-common3 (48c64a0) will not change coverage.
The diff coverage is n/a.

❗ Current head 886bc6e differs from pull request most recent head 7666fb7. Consider uploading reports for the commit 7666fb7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #195   +/-   ##
============================================
  Coverage        75.16%   75.16%           
============================================
  Files               72       72           
  Lines            10237    10237           
============================================
  Hits              7695     7695           
  Misses            2542     2542           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c64a0...7666fb7. Read the comment docs.

@chapulina chapulina mentioned this pull request Apr 6, 2021
7 tasks
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the expanded changelog

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll enabled auto-merge (squash) April 6, 2021 18:39
@mjcarroll mjcarroll merged commit 2582754 into ign-common3 Apr 6, 2021
@mjcarroll mjcarroll deleted the mjcarroll/3.12.0 branch April 6, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants