Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent console spam when exporting a mesh with multiple texture coordinates #171

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 9, 2021

Signed-off-by: Nate Koenig [email protected]

Bug Report

Summary

Using the ColladaExporter can flood the console with warnings like the following:

[Wrn] [SubMesh.cc:478] Multiple texture coordinate sets exist in submesh: WallPlaster. Checking first set with index: 0

This happens when a mesh has multiple texture coordinates. The ColladaExporter can prevent this by using the SubMesh function calls that specify which texture coordinate set to use.

Checklist

  • Signed all commits for DCO
  • codecheck passed
  • All tests passed
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested a review from mjcarroll as a code owner February 9, 2021 22:08
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #171 (cdb6b2a) into ign-common3 (89b1157) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #171   +/-   ##
============================================
  Coverage        75.06%   75.07%           
============================================
  Files               72       72           
  Lines            10234    10234           
============================================
+ Hits              7682     7683    +1     
+ Misses            2552     2551    -1     
Impacted Files Coverage Δ
graphics/src/ColladaExporter.cc 95.16% <100.00%> (ø)
graphics/src/SubMesh.cc 91.61% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b1157...9a27985. Read the comment docs.

@mjcarroll
Copy link
Contributor

Focal CI failure is unrelated.

@nkoenig nkoenig merged commit af6a871 into ign-common3 Feb 9, 2021
@nkoenig nkoenig deleted the dae_export_prevent_warnings branch February 9, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants