[ign-common3] Miscellaneous Cleanups #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
github-actions
bot
added
🏢 edifice
Codecov Report
@@ Coverage Diff @@
## ign-common3 #107 +/- ##
===============================================
+ Coverage 73.97% 74.00% +0.03%
===============================================
Files 69 69
Lines 9421 9432 +11
===============================================
+ Hits 6969 6980 +11
Misses 2452 2452
Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
misc_cleanups
branch
from
d0ade77 to
f9e2ada
Compare
chapulina
approved these changes
Oct 19, 2020
mjcarroll
added a commit
that referenced
this pull request
Oct 26, 2020
* Use variable substitution to prevent forward port issues * Add string Join functionality * Replace all uses of env with Ignition functions Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Oct 27, 2020
* Use variable substitution to prevent forward port issues * Add string Join functionality * Replace all uses of env with Ignition functions Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Oct 29, 2020
* Use variable substitution to prevent forward port issues * Add string Join functionality * Replace all uses of env with Ignition functions Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things that I found when doing the forward port
CMakeLists.txtfile to keep things from breaking across portsgetenv,setenv,putenv,unsetenvwith Ignition functionality.