Remove check for s3cfg

[nkoenig]

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

I moved the upload_doc.sh script from s3cfg to the aws CLI tool and forgot to remove the s3cfg check. This check is no longer needed, and prevents the nightly documentation job from completing successfully.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[j-rivero]

Seems to me like we copy/pasted this from other place. Seems fine to me to supress the change.

[j-rivero]

I moved the upload_doc.sh script from s3cfg to the aws CLI tool and forgot to remove the s3cfg check. This check is no longer needed, and prevents the nightly documentation job from completing successfully.

Out of curiosity, how is the script authenticated to use the AWS cli client?

[nkoenig]

I moved the upload_doc.sh script from s3cfg to the aws CLI tool and forgot to remove the s3cfg check. This check is no longer needed, and prevents the nightly documentation job from completing successfully.

Out of curiosity, how is the script authenticated to use the AWS cli client?

The AWS cli client relies on the ~/.aws/credentials file, which stores the key information. The credentials file can be generated using:

aws configure set aws_access_key_id YOUR_ACCESS_KEY
aws configure set aws_secret_access_key YOUR_SECRET_KEY
aws configure set default.region us-east-1