Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LTCG flag on Windows builds #251

Merged
merged 3 commits into from
May 24, 2022
Merged

Add LTCG flag on Windows builds #251

merged 3 commits into from
May 24, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented May 6, 2022

🦟 Bug fix

Summary

Include LTCG flags as suggested by the own compiler since we are using GL

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from mxgrey as a code owner May 6, 2022 12:18
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels May 6, 2022
@j-rivero j-rivero closed this May 9, 2022
@j-rivero j-rivero reopened this May 9, 2022
@mjcarroll mjcarroll requested a review from scpeters as a code owner May 24, 2022 14:08
@mjcarroll
Copy link
Contributor

Just wanted to add a note before merging:

This flag shouldn't be changing any behavior, as our builds already have this warning in it from enabling /GL

[33.391s]   Environment.obj : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance

Additionally, the documentation for /LTCG says that it is implied for /GL: https://docs.microsoft.com/en-us/cpp/build/reference/ltcg-link-time-code-generation?view=msvc-170

Worst case is that this is a no-op, best case is that it cleans up some warnings.

@mjcarroll mjcarroll merged commit 035016c into ign-cmake2 May 24, 2022
@mjcarroll mjcarroll deleted the jrviero/ltcg branch May 24, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants