Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving CONFIG test #235

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Conversation

harshmahesheka
Copy link
Contributor

@harshmahesheka harshmahesheka commented Apr 14, 2022

🎉 New feature

Summary

Improves tests for CONFIG mode in ign_find_package to give error while finding wrong package as discussed in #230 (review)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Verified

This commit was signed with the committer’s verified signature.
paulober Paul
Signed-off-by: Harsh Mahesheka <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 14, 2022
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the test, this looks pretty good! I left a few minor comments below about removing extra whitespace.

Also, as per the style guide, our indents are 2 spaces, but it looks like you're using 4 spaces for indentation in the CMakeLists.txt. Would you mind fixing that as well?

examples/use_config_ifp/CMakeLists.txt Outdated Show resolved Hide resolved
examples/use_config_ifp/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Harsh Mahesheka <[email protected]>
@harshmahesheka
Copy link
Contributor Author

Sorry for these mistakes, I will keep these in mind from the next time. Also, I have committed the required changes.

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adlarkin adlarkin merged commit a6c7b94 into gazebosim:ign-cmake2 Apr 14, 2022
@harshmahesheka harshmahesheka deleted the test_config branch April 14, 2022 20:11
harshmahesheka added a commit to harshmahesheka/ign-cmake that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants