Fix UNIX check for missing components in OGRE2. Be more verbose with components #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents Signed-off-by: Jose Luis Rivero <[email protected]>
github-actions
bot
added
Gazebo 1️1️
mjcarroll
approved these changes
Apr 4, 2022
harshmahesheka
pushed a commit
to harshmahesheka/ign-cmake
that referenced
this pull request
Apr 5, 2022
…nents (gazebosim#220) Signed-off-by: Jose Luis Rivero <[email protected]> Signed-off-by: Harsh Mahesheka <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check
if (NOT "OGRE2-${component}" STREQUAL "OGRE2-${component}-NOTFOUND")is going to return always true sinceOGRE2-${component}is never going to beOGRE2-${component}-NOTFOUND. What we really want to check is the content of the whole variable which, if I'm not wrong, should be:${OGRE2-${component}}.The pull request includes a bit of output for the user to know when the detection of OGRE2 is failing the status of each component. Otherwise is hard to know what's going on. Example:
Current example in 2.2 (bug included that say OGRE2 was found, using a "fake component")
With this PR: