Run ign-cmake's copy of check_test_ran #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignition CMake has been running
check_test_ran.py
scripts contained in each Ignition library. But these scripts are all very similar, if not exactly the same. It's much more convenient to maintain a single copy of this script that all libraries can use.check_test_ran
to match the one on ign-gazebo so that it prints meaningful test names.tools
directory alongsidebenchmark
andcoverage
.tools/doc_check.sh
, which is not used yet, but once it's installed, it could be used from CMake instead of downloading it from GitHub, see Add documentation check with doxygen gazebo-tooling/action-gz-ci#30.tools/code_check.sh
script, which I think doesn't have any use currently.I don't believe any changes are needed in https://github.com/ignition-release/ign-cmake2-release to install these files, because
benchmark
andcoverage
are already being installed correctly.Test it
Install this branch with this PR gazebosim/gz-math#211, which removes that library's own copy of the script.
Checklist
ign-math
☝️codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸