Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 ➡️ 3 #156

Merged
merged 78 commits into from
Mar 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
598ee27
Use shorter names to make windows happy
j-rivero Nov 20, 2019
287efcb
Reduce name for core_no_deps
j-rivero Nov 20, 2019
3560706
fix test, only folder names have changed, package names are still the…
scpeters Nov 20, 2019
a57fe90
Close branch ign-cmake2_short_names
scpeters Nov 21, 2019
63f9aa3
Merged in ign-cmake2_short_names (pull request #180)
scpeters Nov 21, 2019
9e8404f
Use mathjax to render equations
nkoenig Feb 7, 2020
417305a
Close branch use mathjax
chapulina Feb 14, 2020
f109bbb
Merged in use mathjax (pull request #181)
chapulina Feb 14, 2020
4ff79d0
Fix use of FindZIP without pkg-config
traversaro Mar 22, 2020
b9dbe85
Merged in traversaro/ign-cmake-7/Silvio-Traversaro/fix-use-of-findzip…
scpeters Mar 30, 2020
9c5b0d9
Preparing for ign-cmake 2.2.0 release
nkoenig Apr 6, 2020
f959d2f
Changelog
nkoenig Apr 6, 2020
8cb76bc
Close branch cmake2-2-0
nkoenig Apr 6, 2020
b4fe3af
Merged in cmake2-2-0 (pull request #183)
nkoenig Apr 6, 2020
2a379b7
Added tag ignition-cmake2_2.2.0 for changeset 8093f0df9e9e
nkoenig Apr 6, 2020
ebde577
Added tag ignition-cmake2_2.2.0 for changeset 65f0d7e6fa06
nkoenig Apr 6, 2020
fe27cfd
add test illustrating bug that private dependencies are not specified…
scpeters Apr 8, 2020
e4074e4
fix syntax error in test
scpeters Apr 8, 2020
55cf03a
fix _PKGCONFIG_TYPE variable name
scpeters Apr 8, 2020
15c1a5f
the test wasn't actually failing to illustrate the problem; fix that …
scpeters Apr 8, 2020
b2dc5cf
merge with pkgconfig_requires_private_broken_test
scpeters Apr 8, 2020
b540ddc
copyright year
iche033 Apr 8, 2020
c2e1033
Close branch pkgconfig_requires_private
scpeters Apr 10, 2020
421b651
Merged in pkgconfig_requires_private (pull request #184)
scpeters Apr 10, 2020
976141e
[ign-cmake2] Add .gitignore (#76)
Apr 21, 2020
d85faab
[ign-cmake2] Update BitBucket links (#74)
chapulina Apr 22, 2020
8e5305e
Add codeowner (#82)
mxgrey Apr 28, 2020
2d1b1b3
PR collection labeler
chapulina Apr 28, 2020
600cc52
Merge branch 'ign-cmake2' into collection_labeler
chapulina Apr 28, 2020
b28cfb1
Merge pull request #86 from ignitionrobotics/collection_labeler
chapulina Apr 28, 2020
2f5c317
Fix use of FindYAML.cmake and FindJSONCPP without pkg-config (#79)
traversaro Apr 30, 2020
4b4d394
[ign-cmake2] Workflow updates (#91)
chapulina May 4, 2020
f033612
Fix use of FindIgnOGRE2 on Windows if OGRE2 is not found (#94)
traversaro May 11, 2020
961254e
Disable long-running buildsystem tests by default (#97) (#100)
mjcarroll Jun 5, 2020
b3116af
Add support for finding several dependencies without pkg-config (#95)
traversaro Jun 12, 2020
56f680f
FindFreeImage: find vcpkg's FreeImage on *nix (#105)
traversaro Jul 13, 2020
43e0df4
FindUUID: Export include path as expected by Ignition Libraries (#104)
traversaro Jul 27, 2020
43f4482
Add Focal CI on actions (#106)
chapulina Aug 4, 2020
7419c27
Add ExtraTestMacros feature (#102)
j-rivero Aug 7, 2020
5e32463
Prepare for version 2.3.0 (#107)
j-rivero Aug 7, 2020
220e990
Added an option to include generated code in the ign_create_docs funt…
ahcorde Aug 13, 2020
9062749
Bump to 2.4.0 (#110)
chapulina Aug 21, 2020
6fb610a
Add additional input directories to parse when generating documentati…
nkoenig Sep 3, 2020
eac0b65
⬆️ 2.5.0 (#113)
chapulina Sep 8, 2020
9f14dca
find_package fixes for TINYXML2 and ZeroMQ (#112)
joxoby Sep 28, 2020
dfab7c0
Improve fork experience (#118)
chapulina Oct 19, 2020
c8a4718
Revert "find_package fixes for TINYXML2 and ZeroMQ (#112)" (#120)
mjcarroll Oct 23, 2020
a559c57
Correct CMake Logic and update cpplint to Python3 (#117)
mjcarroll Nov 10, 2020
6a646e9
FindIgnOGRE2: prefer versioned component libraries (#125)
scpeters Nov 16, 2020
106187d
Fix FindIgnOgre on Windows when not using vcpkg (#124)
traversaro Nov 16, 2020
e77122d
Added build-essential and cmake to packages.apt (#130)
adlarkin Dec 3, 2020
ee8bad6
Prepare for 2.6.0 release (#131)
mjcarroll Dec 8, 2020
3aec72e
Revert python to optional dependency (#132)
scpeters Dec 10, 2020
7085179
Bump to 2.6.1, update changelog (#133)
scpeters Dec 10, 2020
4118be2
FindUUID: Always define UUID::UUID on Apple platforms (#128)
traversaro Dec 15, 2020
9edf0a7
Remove deprecated doxygen configurations (#136)
mjcarroll Dec 21, 2020
3f222bf
Generate doxygen tutorials for ign-cmake (#137)
chapulina Dec 22, 2020
aaf3435
Enable make codecheck for ign-cmake (#138)
chapulina Dec 22, 2020
07b793f
Generate valid visibility macros by avoiding hyphens (#135)
j-rivero Dec 30, 2020
f5e6d34
⬆️ 2.6.2 (#142)
chapulina Dec 30, 2020
0d0c814
Suppress warning C5205 on Windows (#141)
chapulina Jan 5, 2021
0253110
Make ign-cmake consider hpp files headers as well (#143)
mjcarroll Jan 5, 2021
522e7d4
Add an option to disable docs when building (#144)
mjcarroll Jan 12, 2021
51a91db
Tutorial about developing with cmake and colcon (#145)
mjcarroll Jan 13, 2021
bed3f7b
Set CMake's CMP0079 policy (#146)
mjcarroll Jan 16, 2021
f78d69e
Windows installation via conda-forge (#139)
mabelzhang Jan 21, 2021
b03ca34
Ensure relocatable config files (#129)
Pro Feb 4, 2021
f150619
Bump to 2.7.0~pre1 (#147)
scpeters Feb 4, 2021
e49e95b
Added issue & PR templates (#148)
jennuine Feb 5, 2021
e8add1a
fixed repo link (#149)
jennuine Feb 5, 2021
a00a8c9
Update codeowners (#151)
adlarkin Feb 10, 2021
b58ce50
Added port & release to PR templates (#152)
jennuine Feb 12, 2021
f0382f5
Fix codeownders (#155)
adlarkin Feb 16, 2021
aac33b3
Remove issue & PR templates (#153)
jennuine Feb 16, 2021
f907b0b
Support imported targets in FindIgnOGRE.cmake (#150)
peci1 Feb 25, 2021
4d2a19a
README tweaks (#158)
chapulina Feb 25, 2021
96faa49
fix cmake message types (#159)
mabelzhang Feb 26, 2021
a5254d3
2 ➡️ 3
chapulina Feb 26, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# More info:
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

* @mxgrey
* @mxgrey @adlarkin @j-rivero
3 changes: 3 additions & 0 deletions .github/ci/packages.apt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
build-essential
cmake
pkg-config
29 changes: 29 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Ubuntu CI

on: [push, pull_request]

jobs:
bionic-ci:
runs-on: ubuntu-latest
name: Ubuntu Bionic CI
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Compile and test
id: ci
uses: ignition-tooling/action-ignition-ci@master
with:
cmake-args: '-DBUILDSYSTEM_TESTING=True'
codecov-token: ${{ secrets.CODECOV_TOKEN }}
focal-ci:
runs-on: ubuntu-latest
name: Ubuntu Focal CI
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Compile and test
id: ci
uses: ignition-tooling/action-ignition-ci@focal
with:
cmake-args: '-DBUILDSYSTEM_TESTING=True'

2 changes: 1 addition & 1 deletion .github/workflows/pr-collection-labeler.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: PR Collection Labeler

on: pull_request
on: pull_request_target

jobs:
pr_collection_labeler:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/triage.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
on:
issues:
types: [opened]
pull_request:
pull_request_target:
types: [opened]
name: Ticket opened
jobs:
Expand Down
31 changes: 29 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ include(IgnCMake)

#--------------------------------------
# Set up the project
ign_configure_project()
ign_configure_project(VERSION_SUFFIX pre1)

#--------------------------------------
# Set project-specific options
Expand Down Expand Up @@ -56,6 +56,7 @@ set(ign_version_output "${PROJECT_NAME_LOWER}-config-version.cmake")
set(ign_config_install_dir "${CMAKE_INSTALL_DATAROOTDIR}/cmake/${PROJECT_NAME_LOWER}")
set(ign_pkgconfig_input "${CMAKE_CURRENT_SOURCE_DIR}/config/ignition-cmake.pc.in")
set(ign_pkgconfig_output "${CMAKE_BINARY_DIR}/ignition-cmake${PROJECT_VERSION_MAJOR}.pc")
set(ign_pkgconfig_install_dir "${IGN_LIB_INSTALL_DIR}/pkgconfig")
set(ign_utilities_target ${PROJECT_EXPORT_NAME}-utilities)
set(ign_utilities_import_target_name ${PROJECT_EXPORT_NAME}::${ign_utilities_target})
set(ign_utilities_target_output_filename "${ign_utilities_target}-targets.cmake")
Expand Down Expand Up @@ -86,11 +87,16 @@ install(

#--------------------------------------
# Configure and install the pkgconfig file (needed for utilities headers)
file(RELATIVE_PATH
IGN_PC_CONFIG_RELATIVE_PATH_TO_PREFIX
"${CMAKE_INSTALL_PREFIX}/${ign_pkgconfig_install_dir}"
"${CMAKE_INSTALL_PREFIX}"
)
configure_file(${ign_pkgconfig_input} ${ign_pkgconfig_output} @ONLY)

install(
FILES ${ign_pkgconfig_output}
DESTINATION ${IGN_LIB_INSTALL_DIR}/pkgconfig
DESTINATION ${ign_pkgconfig_install_dir}
COMPONENT pkgconfig)

#============================================================================
Expand Down Expand Up @@ -182,3 +188,24 @@ if (BUILD_TESTING AND BUILDSYSTEM_TESTING)

add_subdirectory(examples)
endif()

# Codecheck
set(CPPCHECK_DIRS
${CMAKE_SOURCE_DIR}/examples
)
set(CPPCHECK_INCLUDE_DIRS
${CMAKE_SOURCE_DIR}/include
${CMAKE_SOURCE_DIR}/examples
)
set(IGNITION_CMAKE_CODECHECK_DIR "${CMAKE_CURRENT_SOURCE_DIR}/codecheck")
include(IgnCodeCheck)
ign_setup_target_for_codecheck()

# Docs
set(IGNITION_CMAKE_DOXYGEN_DIR "${CMAKE_CURRENT_SOURCE_DIR}/doc/doxygen")
configure_file(${CMAKE_SOURCE_DIR}/api.md.in ${CMAKE_BINARY_DIR}/api.md)
configure_file(${CMAKE_SOURCE_DIR}/tutorials.md.in ${CMAKE_BINARY_DIR}/tutorials.md)
ign_create_docs(
API_MAINPAGE_MD "${CMAKE_BINARY_DIR}/api.md"
TUTORIALS_MAINPAGE_MD "${CMAKE_BINARY_DIR}/tutorials.md"
)
114 changes: 113 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,118 @@
## Ignition CMake 2.x

### Ignition CMake 2.x.x
### Ignition CMake 2.X.X (20XX-XX-XX)

### Ignition CMake 2.7.0 (2021-XX-XX)

1. Set cmake CMP0079 policy
* [Pull request 146](https://github.com/ignitionrobotics/ign-cmake/pull/146)

1. Tutorial about building with cmake and colcon
* [Pull request 145](https://github.com/ignitionrobotics/ign-cmake/pull/145)

1. Add an option to disable docs when building
* [Pull request 144](https://github.com/ignitionrobotics/ign-cmake/pull/144)

1. Install hpp files as headers
* [Pull request 143](https://github.com/ignitionrobotics/ign-cmake/pull/143)

1. Suppress warning C5205 on Windows
* [Pull request 141](https://github.com/ignitionrobotics/ign-cmake/pull/141)

1. Windows installation instructions via conda-forge
* [Pull request 139](https://github.com/ignitionrobotics/ign-cmake/pull/139)

1. Ensure relocatable config files
* [Pull request 129](https://github.com/ignitionrobotics/ign-cmake/pull/129)

### Ignition CMake 2.6.2 (2020-12-29)

1. FindUUID: Always define UUID::UUID on Apple platforms
* [Pull request 128](https://github.com/ignitionrobotics/ign-cmake/pull/128)

1. Remove deprecated doxygen configurations
* [Pull request 136](https://github.com/ignitionrobotics/ign-cmake/pull/136)

1. Generate doxygen tutorials for ign-cmake
* [Pull request 137](https://github.com/ignitionrobotics/ign-cmake/pull/137)

1. Enable make codecheck for ign-cmake
* [Pull request 138](https://github.com/ignitionrobotics/ign-cmake/pull/138)

1. Generate valid visibility macros by replacing hyphens in component name
* [Pull request 135](https://github.com/ignitionrobotics/ign-cmake/pull/135)

### Ignition CMake 2.6.1 (2020-12-10)

1. Revert python to optional dependency
* [Pull request 132](https://github.com/ignitionrobotics/ign-cmake/pull/132)

### Ignition CMake 2.6.0 (2020-12-08)

1. Added build-essential and cmake to packages.apt
* [Pull request 130](https://github.com/ignitionrobotics/ign-cmake/pull/130)

1. Fix FindIgnOgre on Windows when not using vcpkg
* [Pull request 124](https://github.com/ignitionrobotics/ign-cmake/pull/124)

1. FindIgnOGRE2: prefer versioned component libraries
* [Pull request 125](https://github.com/ignitionrobotics/ign-cmake/pull/125)

1. Correct CMake logic and update cpplint to Python3
* [Pull request 117](https://github.com/ignitionrobotics/ign-cmake/pull/117)

1. Improve fork experience
* [Pull request 118](https://github.com/ignitionrobotics/ign-cmake/pull/118)

### Ignition CMake 2.5.0 (2020-09-05)

1. Add additional input directories to parse when generating documentation
* [Pull request 111](https://github.com/ignitionrobotics/ign-cmake/pull/111)

### Ignition CMake 2.4.0 (2020-08-20)

1. Added an option to include generated code in the ign_create_docs function
* [Pull request 108](https://github.com/ignitionrobotics/ign-cmake/pull/108)

### Ignition CMake 2.3.0 (2020-08-07)

1. New macros to help with filter google-test in some platforms
* [Pull request 102](https://github.com/ignitionrobotics/ign-cmake/pull/102)

1. Disable long-running buildsystem tests by default
* [Pull request 97](https://github.com/ignitionrobotics/ign-cmake/pull/97)

1. Fix use of FindYAML.cmake and FindJSONCPP without pkg-config
* [Pull request 79](https://github.com/ignitionrobotics/ign-cmake/pull/79)

1. Fix use of FindIgnOGRE2 on Windows if OGRE2 is not found
* [Pull request 94](https://github.com/ignitionrobotics/ign-cmake/pull/94)
* Thanks to Silvio Traversaro

1. FindUUID: Export include path as expected by Ignition Libraries #104
* [Pull request 104](https://github.com/ignitionrobotics/ign-cmake/pull/104)
* Thanks to Silvio Traversaro

1. Make the OGRE plugin path discovery portable
* [Pull request 101](https://github.com/ignitionrobotics/ign-cmake/pull/101)
* Thanks to Sean Yen

### Ignition CMake 2.2.0

1. Fix use of FindZIP without pkg-config.
* [BitBucket pull request 182](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/182)

1. Use mathjax to render equations.
* [BitBucket pull request 181](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/181)

1. Reduce example names to fix build on Windows
* [BitBucket pull request 180](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/180)

1. Fix doxygen deprecation filter
* [BitBucket pull request 160](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/160)

1. Change the diamond link icon to a material design link
* [BitBucket pull request 159](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/159)

1. Disable long-running buildsystem tests by default.
* [Pull request 97](https://github.com/ignitionrobotics/ign-cmake/pull/97)
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@

Build | Status
-- | --
Test coverage | [![codecov](https://codecov.io/bb/ignitionrobotics/ign-cmake/branch/default/graph/badge.svg)](https://codecov.io/bb/ignitionrobotics/ign-cmake)
Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-default-bionic-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-default-bionic-amd64)
Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-default-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-default-homebrew-amd64)
Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-default-windows7-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-default-windows7-amd64)
Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-cmake/branch/default/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-cmake)
Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-bionic-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-bionic-amd64)
Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-homebrew-amd64)
Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-windows7-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-windows7-amd64)

# Table of Contents

Expand Down
10 changes: 10 additions & 0 deletions api.md.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Ignition @IGN_DESIGNATION_CAP@

Ignition @IGN_DESIGNATION_CAP@ is a component in Ignition, a set of libraries
designed to rapidly develop robot and simulation applications.

## License

The code associated with this documentation is licensed under an [Apache 2.0 License](https://www.apache.org/licenses/LICENSE-2.0).

This documentation is licensed under a [Creative Commons Attribution 4.0 International License](http://creativecommons.org/licenses/by/4.0/).
14 changes: 13 additions & 1 deletion cmake/FindAVCODEC.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,16 @@
########################################
# Find avcodec
include(IgnPkgConfig)
ign_pkg_check_modules(AVCODEC libavcodec)
ign_pkg_check_modules_quiet(AVCODEC libavcodec)

if(NOT AVCODEC_FOUND)
include(IgnManualSearch)
ign_manual_search(AVCODEC
HEADER_NAMES "libavcodec/avcodec.h"
LIBRARY_NAMES "avcodec")
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(
AVCODEC
REQUIRED_VARS AVCODEC_FOUND)
34 changes: 33 additions & 1 deletion cmake/FindAVDEVICE.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,36 @@ set(av_minor ${AVDEVICE_FIND_VERSION_MINOR})
set(av_patch ${AVDEVICE_FIND_VERSION_PATCH})

include(IgnPkgConfig)
ign_pkg_check_modules(AVDEVICE "libavdevice >= ${av_major}.${av_minor}.${av_patch}")
ign_pkg_check_modules_quiet(AVDEVICE "libavdevice >= ${av_major}.${av_minor}.${av_patch}")

if(NOT AVDEVICE_FOUND)
include(IgnManualSearch)
ign_manual_search(AVDEVICE
HEADER_NAMES "libavdevice/avdevice.h"
LIBRARY_NAMES "avdevice")

# Version check
if(AVDEVICE_FOUND)
file(READ "${AVDEVICE_INCLUDE_DIRS}/libavdevice/version.h" ver_file)

string(REGEX MATCH "LIBAVDEVICE_VERSION_MAJOR[ \t\r\n]+([0-9]*)" _ ${ver_file})
set(ver_major ${CMAKE_MATCH_1})

string(REGEX MATCH "LIBAVDEVICE_VERSION_MINOR[ \t\r\n]+([0-9]*)" _ ${ver_file})
set(ver_minor ${CMAKE_MATCH_1})

string(REGEX MATCH "LIBAVDEVICE_VERSION_MICRO[ \t\r\n]+([0-9]*)" _ ${ver_file})
set(ver_patch ${CMAKE_MATCH_1})

set(AVDEVICE_VERSION "${ver_major}.${ver_minor}.${ver_patch}")

if(AVDEVICE_VERSION VERSION_LESS AVDEVICE_FIND_VERSION)
set(AVDEVICE_FOUND FALSE)
endif()
endif()
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(
AVDEVICE
REQUIRED_VARS AVDEVICE_FOUND)
14 changes: 13 additions & 1 deletion cmake/FindAVFORMAT.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,16 @@
########################################
# Find AV format
include(IgnPkgConfig)
ign_pkg_check_modules(AVFORMAT libavformat)
ign_pkg_check_modules_quiet(AVFORMAT libavformat)

if(NOT AVFORMAT_FOUND)
include(IgnManualSearch)
ign_manual_search(AVFORMAT
HEADER_NAMES "libavformat/avformat.h"
LIBRARY_NAMES "avformat")
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(
AVFORMAT
REQUIRED_VARS AVFORMAT_FOUND)
14 changes: 13 additions & 1 deletion cmake/FindAVUTIL.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,16 @@
########################################
# Find avutil
include(IgnPkgConfig)
ign_pkg_check_modules(AVUTIL libavutil)
ign_pkg_check_modules_quiet(AVUTIL libavutil)

if(NOT AVUTIL_FOUND)
include(IgnManualSearch)
ign_manual_search(AVUTIL
HEADER_NAMES "libavutil/avutil.h"
LIBRARY_NAMES "avutil")
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(
AVUTIL
REQUIRED_VARS AVUTIL_FOUND)
2 changes: 1 addition & 1 deletion cmake/FindFreeImage.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ if (NOT WIN32)
endif(NOT FreeImage_INCLUDE_DIRS)
mark_as_advanced(FreeImage_INCLUDE_DIRS)

find_library(FreeImage_LIBRARIES freeimage)
find_library(FreeImage_LIBRARIES NAMES freeimage FreeImage)
if(FreeImage_LIBRARIES)
set(FreeImage_FOUND true)
else()
Expand Down
7 changes: 5 additions & 2 deletions cmake/FindIgnOGRE.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ else()
set(prefix "")
# vcpkg uses special directory (lib/manual-link/) to place libraries
# with main sysmbol like OgreMain.
if(ogre_lib MATCHES "OgreMain" AND NOT IS_ABSOLUTE "${ogre_lib}")
if(ogre_lib MATCHES "OgreMain" AND NOT IS_ABSOLUTE "${ogre_lib}" AND EXISTS "${OGRE_LIBRARY_DIRS}/manual-link/")
set(prefix "${OGRE_LIBRARY_DIRS}/manual-link/")
elseif(ogre_lib MATCHES "Ogre" AND NOT IS_ABSOLUTE "${ogre_lib}")
set(prefix "${OGRE_LIBRARY_DIRS}/")
Expand All @@ -191,7 +191,10 @@ else()
# Some Ogre libraries are not using the .lib extension
set(postfix "")
if(NOT ogre_lib MATCHES ".lib$")
set(postfix ".lib")
# Do not consider imported targets as libraries
if(NOT ogre_lib MATCHES "::")
set(postfix ".lib")
endif()
endif()
set(lib_fullpath "${prefix}${ogre_lib}${postfix}")
endif()
Expand Down
Loading