Revert python to optional dependency (#132)

Prior to #117, python was an optional dependency; this restores that behavior. * IgnPython: find PythonInterp with QUIET instead of REQUIRED * IgnCodeCheck: skip cpplint if python is not found Signed-off-by: Steve Peters <[email protected]>
gazebosim · Dec 10, 2020 · 3aec72e · 3aec72e
1 parent ee8bad6
commit 3aec72e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/cmake/IgnCodeCheck.cmake b/cmake/IgnCodeCheck.cmake
@@ -40,12 +40,15 @@ function(ign_setup_target_for_codecheck)
     COMMAND ${CPPCHECK_PATH} ${CPPCHECK_BASE} --enable=missingInclude `${CPPCHECK_FIND}`
   )
 
-  add_custom_target(cpplint
-    # cpplint cppcheck
-    COMMAND ${PYTHON_EXECUTABLE} ${IGNITION_CMAKE_CODECHECK_DIR}/cpplint.py --extensions=cc,hh --quiet `${CPPCHECK_FIND}`
-  )
-
   add_custom_target(codecheck
-    DEPENDS cpplint cppcheck
+    DEPENDS cppcheck
   )
+
+  if(PYTHONINTERP_FOUND)
+    add_custom_target(cpplint
+      COMMAND ${PYTHON_EXECUTABLE} ${IGNITION_CMAKE_CODECHECK_DIR}/cpplint.py --extensions=cc,hh --quiet `${CPPCHECK_FIND}`
+    )
+
+    add_dependencies(codecheck cpplint)
+  endif()
 endfunction()
diff --git a/cmake/IgnPython.cmake b/cmake/IgnPython.cmake
@@ -22,4 +22,4 @@ if(NOT PYTHON_VERSION)
   set(PYTHON_VERSION "3")
 endif()
 
-find_package(PythonInterp ${PYTHON_VERSION} REQUIRED)
+find_package(PythonInterp ${PYTHON_VERSION} QUIET)