Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup various functionality based on feedback #26

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Cleanup various functionality based on feedback #26

merged 4 commits into from
Oct 27, 2020

Conversation

mjcarroll
Copy link
Collaborator

@mjcarroll mjcarroll commented Oct 23, 2020 •
edited
Loading

Some various cleanups and refactorings:

  • Run Buildifier to lint all bazel files.
  • Move common definitions to a build_defs file.
  • Change TinyXML2 to be a correctly exported dependency.

Incorporated changes in ign-math (gazebosim/gz-math#171)
Incorporated changes in ign-msgs (gazebosim/gz-msgs#95)

@mjcarroll
Add build_defs and config_header functionality
fd1e1b0 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Buildifier
b6c4b3f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Incorporate cleanups and feedback
ac574b8 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Refactor TinyXML2 dependency
918e50d 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from JShep1 October 23, 2020 19:15
JShep1
JShep1 approved these changes Oct 27, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a linter of some sort we can start using for formatting?

@mjcarroll
Copy link
Collaborator Author

LGTM, is there a linter of some sort we can start using for formatting?

Yes, we should be using buildifier, available in https://github.com/bazelbuild/buildtools

@mjcarroll mjcarroll merged commit 1813a3e into master Oct 27, 2020
@mjcarroll mjcarroll deleted the feedback branch October 27, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JShep1 JShep1 JShep1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @JShep1