Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manpage installation when GZ_CLI_EXECUTABLE_NAME is used #3370

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

The install steps is failing when GZ_CLI_EXECUTABLE_NAME is being used in the step to install the man files. This happens after #3368.

-- Installing: /home/jenkins/workspace/gazebo11-debbuilder/build/gazebo/debian/tmp/usr/bin/gz11
-- Set runtime path of "/home/jenkins/workspace/gazebo11-debbuilder/build/gazebo/debian/tmp/usr/bin/gz11-11.15.0" to ""
CMake Error at tools/cmake_install.cmake:74 (file):
  file INSTALL cannot find
  "/home/jenkins/workspace/gazebo11-debbuilder/build/gazebo/obj-x86_64-linux-gnu/tools/gz11.1.gz":
  No such file or directory.
Call Stack (most recent call first):
  cmake_install.cmake:103 (include)


make[1]: *** [Makefile:100: install] Error 1

The PR implements modifies slightly the roffman macro to support a third optional parameter that defines a different generated name. That parameter is being used when GZ_CLI_EXECUTABLE_NAME is defined.

Tested with GZ_CLI_EXECUTABLE_NAME in Build Status.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Copy link
Member

homebrew build fixed in #3373

@scpeters scpeters merged commit 9442fa6 into gazebo11 Feb 21, 2024
8 of 10 checks passed
@scpeters scpeters deleted the jrivero/fix_gz_manpage branch February 21, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants