Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dome interior updates #8

Merged
merged 12 commits into from
Sep 14, 2022
Merged

Dome interior updates #8

merged 12 commits into from
Sep 14, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Sep 12, 2022

🎉 New feature

Summary

  • added interior dome models
  • updated base ramp model (previously only half was shown)
  • converted most textures from png to jpg

2022-09-13T16:31:55 150667469

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine requested a review from iche033 September 12, 2022 23:25
@jennuine jennuine self-assigned this Sep 12, 2022
@jennuine jennuine changed the title Add inner dome sky & floor Add inner dome sky, floor, & garden level Sep 13, 2022
@jennuine
Copy link
Contributor Author

Is it just me or does <emissive_map> not provide any notable difference other than load time taking slightly longer?

<emissive_map>materials/textures/InnerDome_Emissive.jpg</emissive_map>

@iche033
Copy link
Contributor

iche033 commented Sep 13, 2022

ouch, it's a bug. Can you give gazebosim/gz-rendering#723 a try?

@jennuine
Copy link
Contributor Author

Much better thanks!

2022-09-13T15:11:00 117894247

@jennuine jennuine changed the title Add inner dome sky, floor, & garden level Dome interior updates Sep 13, 2022
@jennuine
Copy link
Contributor Author

This PR is ready for review now.

4a350c6 I moved the dome to it's own link so we can turn on/off transparency through the GUI. I thought it might be helpful for debugging features

@iche033
Copy link
Contributor

iche033 commented Sep 14, 2022

I think we can remove flat_normal.jpg since it's not used any more.

Same for MoonHeightmap.jpg. I believe this is converted form the 16 bit MoonHeightmap.png image. I did not use the 16 bit version because I had issue loading it in gz sim. The Image class in gz-common floods the console with lots of out of range msg. So I ended up using the 8 bit version.

Other than that, this looks good to me

Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine merged commit b8800a1 into main Sep 14, 2022
@jennuine jennuine deleted the jennuine/mesh_updates branch September 14, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants