Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description to tutorials and added a tutorials.yaml #66

Merged
merged 4 commits into from
Aug 25, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 21, 2020

This PR is related to this issue #55 and with these others PR:

This PR includes:

  • Added tutorial.yaml file to get all the tutorials under the releases specified in this file.
  • Added description for all the tutorials

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 21, 2020
@ahcorde ahcorde self-assigned this Aug 21, 2020
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint labels Aug 21, 2020
Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

acropolis/index.yaml Outdated Show resolved Hide resolved
blueprint/index.yaml Outdated Show resolved Hide resolved
citadel/index.yaml Outdated Show resolved Hide resolved
ahcorde and others added 3 commits August 24, 2020 19:21
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
@maryaB-osr
Copy link
Contributor

I like the set up with the cards, but I think tutorials should be under docs, just logically people will expect them there right?
Is there a better reason to have them separate?

@ahcorde ahcorde merged commit 44abcad into master Aug 25, 2020
@ahcorde ahcorde deleted the ahcorde/tutorials/description_and_yaml branch August 25, 2020 06:47
@chapulina
Copy link
Contributor

I agree with @maryaB-osr that we should have the bigger picture in mind before deploying this so we don't have yet another page that confuses users.

The main goal of #55 is to gather the tutorials from this repository, as well as those from all the libraries in a single index, which is not addressed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants