-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds note about how to activate debug symbols during source installation #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colcon build --cmake-args -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Debug
You don't need to use quotes and I think you should remove -DBUILD_TESTING=OFF
,
@ahcorde, I tried without it and it did not work (I checked the workspace/log/logger_all.log for the colcon logs and saw only the first arg loaded and not the second while running cmake). I specially added the -DBUILD_TESTING=OFF because users might want to use these two arguments together which ends up failing if they do it in the obvious way, without quotes. I think these issues shows we should add quotes: colcon/colcon-core#18 , https://buildmedia.readthedocs.org/media/pdf/colcon/released/colcon.pdf (30.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ahcorde , I'll wait for your approval before merging. I don't have a strong opinion about keeping or removing |
Unfortunately, commit doesn't fully comply with the DCO, The commit message does not end with my name and email address. I can fix this. Weird I used git commit -s but didn't work. |
Now it is okay. |
@ahcorde, is it good? What do you think? |
Changes ubuntu&osx documents for citadel, fortress and garden Signed-off by: Onur Berk Tore [email protected]
Changes ubuntu&osx documents for citadel, fortress and garden
🎉 New feature
Closes #245
Summary
Changes ubuntu&osx documents for citadel, fortress and garden.
Test it
Check the documentation for the ubuntu&osx on citadel, fortress and garden.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.