Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds note about how to activate debug symbols during source installation #246

Merged
merged 1 commit into from
May 23, 2022

Conversation

onurtore
Copy link
Contributor

Changes ubuntu&osx documents for citadel, fortress and garden

🎉 New feature

Closes #245

Summary

Changes ubuntu&osx documents for citadel, fortress and garden.

Test it

Check the documentation for the ubuntu&osx on citadel, fortress and garden.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@onurtore onurtore requested a review from mabelzhang as a code owner April 18, 2022 22:19
@github-actions github-actions bot added 🌱 garden Gazebo Garden 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 18, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colcon build --cmake-args -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Debug

You don't need to use quotes and I think you should remove -DBUILD_TESTING=OFF,

@onurtore
Copy link
Contributor Author

onurtore commented Apr 19, 2022

colcon build --cmake-args -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Debug

You don't need to use quotes and I think you should remove -DBUILD_TESTING=OFF,

@ahcorde, I tried without it and it did not work (I checked the workspace/log/logger_all.log for the colcon logs and saw only the first arg loaded and not the second while running cmake). I specially added the -DBUILD_TESTING=OFF because users might want to use these two arguments together which ends up failing if they do it in the obvious way, without quotes.

I think these issues shows we should add quotes: colcon/colcon-core#18 , https://buildmedia.readthedocs.org/media/pdf/colcon/released/colcon.pdf (30.1)

@onurtore onurtore requested a review from ahcorde April 19, 2022 15:04
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina
Copy link
Contributor

@ahcorde , I'll wait for your approval before merging. I don't have a strong opinion about keeping or removing BUILD_TESTING.

@onurtore
Copy link
Contributor Author

onurtore commented Apr 19, 2022

Unfortunately, commit doesn't fully comply with the DCO,

The commit message does not end with my name and email address. I can fix this. Weird I used git commit -s but didn't work.

@onurtore
Copy link
Contributor Author

onurtore commented Apr 19, 2022

Now it is okay.

@onurtore
Copy link
Contributor Author

onurtore commented Apr 20, 2022

@ahcorde, is it good? What do you think?

Changes ubuntu&osx documents for citadel, fortress and garden

Signed-off by: Onur Berk Tore [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Gazebo Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No debug information for colcon
3 participants