-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deploying on github pages with /docs
and /libs
generated by sphinx
#33
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
If I type a URL into the navigation bar, such as
and a similar console message. Does this happen to you? |
I saw the same problem with node If debugging this is too much effort, we could plan to keep this on a web host that we control (with OSUOSL) and support the SPA at the web server level. |
Can you try setting |
I gave this a shot and it now works when I click links but if I navigate directly to localhost:8080/features I get the same recursive redirect issue. |
From testing on https://addisu.taddese.com/docs/home it seems like this is a problem specifically with local dev using http-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one change I'd like to see but otherwise, I think it's okay to proceed even though we have some issues with local development, I don't see them in the published page.
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
This is in support of gazebosim/docs#441 which is part of gazebosim/docs#412. Based on https://github.com/rafgraph/spa-github-pages, this makes it possible to deploy the frontend (this repo) on Github Pages. This PR also removes the
/docs
,/libs
and/lib
routes which are to be handled by the statically generated pages in gazebosim/docs#441. We could remove all the code that handles those routes, but I opted for a smaller PR for now and do the removal in a follow up PR.To test locally,
Open the URL printed out by
http-server
and navigate to/features
. This should work. Now refresh the page or go to the/features
page by typing the full URL. This is what's fixed by this PR and should also work.