ignition.dsl: colcon builds for ign-transport #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new dependency on ign-utils, which also uses colcon for its Windows CI builds, this may be a good time for ign-transport to use colcon as well. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
7 tasks
…lease-tools into scpeters/dsl_colcon_transport
|
I've added 34c1058 my branch |
10 tasks
j-rivero
reviewed
Mar 4, 2021
| @@ -80,6 +80,7 @@ ignition_colcon_win = [ 'gazebo', | |||
| 'physics', | |||
| 'rendering', | |||
| 'sensors', | |||
| 'transport', | |||
There was a problem hiding this comment.
Adding transport here is the right thing, but name is going to change to get the shorter version. Just FYI.
There was a problem hiding this comment.
ok, we'll need to update the ignition_collection dsl; I'll do that in a follow-up
scpeters
commented
Mar 5, 2021
Signed-off-by: Steve Peters <[email protected]>
|
@j-rivero your changes look good, but I can't approve this since I submitted it |
j-rivero
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new dependency on ign-utils in gazebosim/gz-transport#216, which also uses colcon for its Windows CI builds, this may be a good time for ign-transport to use colcon as well. Since ign-transport4 is still supported, this requires gazebo-tooling/gazebodistro#29 before merging.
An alternative is to add a
configure.batscript toign-utils(gazebosim/gz-utils#13).