-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use credential bindings for osrfbuild github token #353
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@scpeters this should allow us to move brew jobs out of master and remove the osrfbuild key and use the token instead. |
Now that releasing has calm down, I'm interested into merging this one. |
testing more here: osrf/homebrew-simulation#1269 (comment) |
this branch is out of date; I just merged with master and will redeploy the DSL: |
the bottle builder currently fails during https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/614/label=osx_catalina/
|
testing the opening of a homebrew PR from it fails because this job actually expects a Linux machine
we should update the script to use |
I've redeployed the brew dsl from master in order to build some bottles |
Resurrecting this: Looking into the errors that appeared in the previous testing deployed:
Somehow the
This clearly fails because our scripts were prepared to use master (a linux box) to interact with Brew via LinuxBrew. I'm going to revert the change to use |
Signed-off-by: Jose Luis Rivero <[email protected]>
This needs update after the works of #1206 . Move to draft. |
Signed-off-by: Jose Luis Rivero <[email protected]>
The PR removes the action of taking the
GITHUB_TOKEN
from the filesystem and implements the credentials plugin from Jenkins on it. There is also a testing job generated that check permission and push capabilities running directly on osX nodes:Linked to: https://github.com/osrf/chef-osrf/pull/55