Support unversioned ci directory #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/ci_dir
branch
from
e40048e to
fd25887
Compare
|
Testing on this PR: gazebosim/gz-math#139 |
Merged
mjcarroll
approved these changes
Jul 29, 2020
j-rivero
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Seems fine to me the changes. One minor point: given that all the 'versioned' mechanism relies on running lsb_release -cs we could abstract the naming a little bit from Ubuntu since it could probably work on any Debian based system including Debian itself. I know that it is probably much easier to understand ubuntu_version than deb_system_version or similar :)
Signed-off-by: Louise Poubel <[email protected]>
|
Changed "ubuntu" to "system" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of #16