Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ign-plugin executable #5

Merged
merged 7 commits into from
May 24, 2022
Merged

Conversation

scpeters
Copy link
Contributor

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from chapulina and j-rivero April 24, 2022 05:16
@j-rivero
Copy link
Contributor

Changes will require gazebosim/gz-plugin#80.

Fixed:

  • The cli app should be placed into libexec and should not in a dev package if possible but in its own package d4bebc3
  • Removed Debian Sid since it has its own package ea55ede
  • Seems like doc-base was complaining about bad paths, do not use wildcards there e483eed
  • lintian exception was broken 6c68ec5

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-rivero , adding a new package for the CLI looks like a different approach from the one suggested for Transport in

Should we use the same pattern for all libraries?

ubuntu/debian/control Outdated Show resolved Hide resolved
@j-rivero
Copy link
Contributor

Testing it here Build Status

@scpeters
Copy link
Contributor Author

Testing it here Build Status

looks good to me

I would approve but I'm the author of this PR

@scpeters
Copy link
Contributor Author

I'll just go ahead and merge

@scpeters scpeters merged commit ccb284b into main May 24, 2022
@scpeters scpeters deleted the scpeters/install_executable branch May 24, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants