Switch to using React-PDF for loading pdfs on the page

[kohsah]

Currently standard object tags are used, we need to compare mobile responsiveness of the current option to react-pdf

[Arunadevi]

Fixed on issue-#6 branch

…

On Tuesday, December 19, 2017, Ashok H ***@***.***> wrote: Currently standard object tags are used, — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADnEEAE0gijyJDiNHgeBaWGLcOTrtcT-ks5tB4jjgaJpZM4RGtaS> .

[kohsah]

Needs page browsing ui

[kohsah]

Two implementations are there in the code-base now ...

1. DocumentPDF - based on react-pdf. Renders pages, but there is no page browsing UI. needs to be implemented. Loading documents of 100s of pages may not be optimal, we need to have on-demand loading of pages.

2. DocumentPDF2 - CURRENT DEFAULT - based on PdfObject which provides a very simple helper API to search to render the appropriate tag as per what is supported by the browser. Does not do any page navigation other than what is provided by the browser. Works well for mobile because it provides the right tags depending on what is supported by the browser.

[Arunadevi]

Pagination can be done as shown in https://github.com/mikecousins/react-pdf-js/blob/master/README.md#usage. It uses pdf.js which you said will work on iPhones too. Is there a reason we reverted back to react-pdf?

…

On Tue, Jan 2, 2018 at 10:03 AM, Ashok H ***@***.***> wrote: Two implementations are there in the code-base now ... 1. DocumentPDF - based on react-pdf <https://github.com/wojtekmaj/react-pdf>. Renders pages, but there is no page browsing UI. needs to be implemented. Loading documents of 100s of pages may not be optimal, we need to have on-demand loading of pages. 2. DocumentPDF2 - CURRENT DEFAULT - based on PdfObject <https://pdfobject.com/> which provides a very simple helper API to search to render the appropriate tag as per what is supported by the browser. Does not do any page navigation other than what is provided by the browser. Works well for mobile because it provides the right tags depending on what is supported by the browser. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADnEEB1_S6lysj69muFyCJfuGQuzAR4Cks5tGbGxgaJpZM4RGtaS> .

[kohsah]

Related gawati/gawati-data#7

[kohsah]

@Arunadevi Pagination looks like this:

1. Needs to link to individual pages like the document paginator
2. The PDF page needs to be in a bigger scale , so we can scale it down for mobile views

[Arunadevi]

Updated pdf-page-links branch. The PDF is scaled to width. But will not reload upon resizing. For mobile view, it loads scaled to width. Should it reload when window is resized?

[kohsah]

@Arunadevi lets not do the reload on resizing. its fine as is. Anyway we have to make a try with linearized PDFs or images, so we tackle this problem at that point.