-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix defaults handling, perform linting #153
Conversation
Co-authored-by: Gaurav Nelson <[email protected]>
The two markdown link errors are both false positives @gaurav-nelson |
@gaurav-nelson do you know what's up with those false positive link checks? |
For GitHub can you see #136 (comment) and add it to the The other one is probably disallowing agents. maybe add it to ignore list as well. |
@gaurav-nelson thanks, done :) |
@sammcj Can you please check the script again, I think the failed workflow is not running with the Also, See https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650177#step:3:154 which outputs the command we are running however the failed check doesn't list the command https://github.com/gaurav-nelson/github-action-markdown-link-check/actions/runs/3140346552/jobs/5101650203? 🤔 |
@gaurav-nelson Oh I see what's going on, it's relying on on all inputs being provided in order to have each parameter in the right place. OK I'll refactor! |
This PR is for two things:
I have refactored the bash parameters to set the defaults if no input is provided, and set the inputs to optional.
cc/ @gaurav-nelson