Issue checkstyle#54(metadata-gen): fix default values

gaurabdg · Aug 18, 2020 · eae5dec · eae5dec
1 parent 4c42f21
commit eae5dec
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/src/main/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadata.java b/src/main/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadata.java
@@ -184,8 +184,7 @@ private List<String> getEnumValues(String enumName) {
      */
     private void constructParams(String checkName, RulesDefinition.NewParam param,
                                         ModulePropertyDetails modulePropertyDetails) {
-        param.setDescription(modulePropertyDetails.getDescription())
-                .setDefaultValue(modulePropertyDetails.getDefaultValue());
+        param.setDescription(modulePropertyDetails.getDescription());
         final String paramType = modulePropertyDetails.getType();
         if (modulePropertyDetails.getValidationType() != null
             && "tokenSet".equals(modulePropertyDetails.getValidationType())) {

diff --git a/src/test/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadataTest.java b/src/test/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadataTest.java
@@ -83,9 +83,6 @@ public void testUpdate() {
                     assertEquals("Description doesn't match for param: " + key,
                             modulePropertyDetails.getDescription(),
                             param.description());
-                    assertEquals("Default value doesn't match for param: " + key,
-                            modulePropertyDetails.getDefaultValue(),
-                            param.defaultValue());
                 }
             });
         });
@@ -113,8 +110,6 @@ public void testCreate() {
                     final RulesDefinition.Param modParam = modRule.param(paramKey);
                     assertEquals("Description doesn't match for param: " + paramKey,
                             origParam.description(), modParam.description());
-                    assertEquals("Default value doesn't match for param: " + paramKey,
-                            origParam.defaultValue(), modParam.defaultValue());
                     assertEquals("Type doesn't match for param: " + paramKey, origParam.type(),
                             modParam.type());
                 }