Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update broken links with working links #9912

Merged
merged 2 commits into from
Nov 14, 2018
Merged

fix(docs): update broken links with working links #9912

merged 2 commits into from
Nov 14, 2018

Conversation

lundgren2
Copy link
Contributor

No description provided.

@lundgren2 lundgren2 requested a review from DSchau November 13, 2018 22:30
@lundgren2 lundgren2 requested a review from a team as a code owner November 13, 2018 22:30
@lundgren2 lundgren2 requested a review from a team November 13, 2018 22:30
@@ -36,4 +36,4 @@ After a little over a month of tinkering on the design during nights and weekend

If you are currently on the fence about static site generators or the JAMstack in general there has never been a better time to jump in. In my humble opinion with these tools it has finally reached the level of maturity to not just be feasible for client work but actually pretty darn amazing.

For those interested the source code for the website I built is available on GitHub: https://github.com/ryanwiemer/knw
For those interested the source code for the website I built is available on GitHub: https://github.com/ryanwiemer/knw-legacy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo seems to point to WordPress theme (not gatsby site). If gatsby site is no longer available we should just remove link to source code (IMO)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I removed the last part with the link!

@pieh
Copy link
Contributor

pieh commented Nov 14, 2018

Thanks for doing this! There's just one small issue with knw repo link (see inline comment above)

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lundgren2!

@pieh pieh changed the title Update broken links with working links fix(docs): update broken links with working links Nov 14, 2018
@pieh pieh merged commit e9f2a6f into gatsbyjs:master Nov 14, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants