-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contributing instructions consistent #8920
Make contributing instructions consistent #8920
Conversation
I still can't get the docs/www site to work locally in development, so I can't verify these changes don't break anything. |
if memory serves, i believe the issue you reported last time has been fixed. Can you provide more detail about the error you're seeing? |
@amberleyromo I don't know the root cause, but I still get the GraphQL error on build, and the main page plus most pages are not viewable (lots of errors in the console). I never added at GitHub key since the last I remembered in that other ticket was to make the build functional without having to do that (since it was only needed for the starter library). |
@siakaramalegos have you deleted the cache? if yes, i'll take a look later tonight when i can get to it! |
@amberleyromo I went ahead and re-pulled this master, deleted www/.cache/ and re-ran |
docs/docs/how-to-contribute.md
Outdated
@@ -76,13 +76,25 @@ a pull request. | |||
|
|||
- Clone the repo and navigate to `/www` | |||
- Run `yarn` to install all of the website's dependencies. | |||
- Run `gatsby develop` to preview the website in `http://localhost:8000` | |||
- Run `yarn develop` to preview the website in `http://localhost:8000` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary as gatsby develop
always runs the local version
@siakaramalegos Are you still getting the same errors as in #5073? I just verified that I do not have a To be extra super sure that the site at Full output from clone and run
If this is still happening to you, there are a few things that I've seen cause issues in the past:
If you're still running into issues, could you please open a new issue with the errors you're seeing? Thanks so much! |
Glad we could get it sorted, @siakaramalegos! Thanks @jlengstorf for troubleshooting/verifying. @siakaramalegos, could you handle the tweak from @KyleAMathews previous review? Then we should be good to go. Thanks! |
@amberleyromo @KyleAMathews switched to |
Accidentally overwrote in conflict resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Connects #8676
Changes instructions from
gatsby develop
toyarn develop
to ensure contributors are using the local version of gatsby.Adds instructions for contributing to the starter showcase into the main contributing instructions since a contributor might not know to also look in www/readme.md for separate instructions.