Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] gatsbygram gravatar #792

Merged
merged 11 commits into from
Apr 11, 2017

Conversation

fabien0102
Copy link
Contributor

Just for fun and test a little bit gatsby 1.0 😉

As @KyleAMathews asked for help on gatsbygram-case-study/index.md, voilà!

I'm using another method to scrape instagram (that permit to have more data) and replace gravatar by retrieve picture url, that's it!

@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 11, 2017

Deploy preview ready!

Built with commit cebc06b

https://deploy-preview-792--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 11, 2017

Deploy preview ready!

Built with commit cebc06b

https://deploy-preview-792--gatsbygram.netlify.com

@fabien0102
Copy link
Contributor Author

The problem with this scrapping method that I haven't got a lot of pictures as before… I think I can do better with a smart merge with previous method

@KyleAMathews
Copy link
Contributor

Oh nifty! I didn't run across the media endpoint when building gatsbygram. That'd allow us to add all the comments, etc.!

It does seem you can paginate to get more photos http://stackoverflow.com/questions/34589096/instagram-media-endpoint-paging

@fabien0102
Copy link
Contributor Author

Nice, I'll try this magic attribute :) (I search into instragram doc API but I've found nothing on this unauth route ^^)

@fabien0102 fabien0102 force-pushed the 1.0-gatsbygram-gravatar branch from 4f63f16 to 2eedeb6 Compare April 11, 2017 17:23
@fabien0102
Copy link
Contributor Author

@KyleAMathews Pagination works as expected :) It's a good base for futur comments :-p (should resolve #791 before maybe)

@KyleAMathews
Copy link
Contributor

Looking great!

One thing that needs fixed still is right now you're only downloading images that are 640x640 instead of the max sized image that's available.

@fabien0102
Copy link
Contributor Author

I can replace /s640x640 by an empty string, it's not very clean but don't have better idea… Any better idea?

@KyleAMathews
Copy link
Contributor

Yup! That's all I did in my original script. Thanks for the updates! I'll merge this in now. I'm going to merge in the Redux PR later so we'll be set to work on improving parsers (or transformer as I'm thinking of calling them) plugins.

@KyleAMathews KyleAMathews merged commit f186b91 into gatsbyjs:1.0 Apr 11, 2017
@fabien0102 fabien0102 deleted the 1.0-gatsbygram-gravatar branch April 12, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants