Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix Gatsbygram Cypress tests #7607

Merged
merged 5 commits into from
Aug 28, 2018
Merged

[v2] Fix Gatsbygram Cypress tests #7607

merged 5 commits into from
Aug 28, 2018

Conversation

vtenfys
Copy link
Contributor

@vtenfys vtenfys commented Aug 24, 2018

  • Add delays to Cypress tests to wait until pages are ready after loading/clicking etc
  • Force a click where Cypress previously threw an error due to one of its children covering it
    • Clicking its children produces the same result, but it's not predictable which one Cypress will detect in front since there are multiple

@vtenfys vtenfys requested a review from KyleAMathews August 24, 2018 17:12
@vtenfys
Copy link
Contributor Author

vtenfys commented Aug 24, 2018

100ms worked locally but it looks like it's too short for Travis. I'll see if I can do this programmatically instead, or if not I'll increase the delay

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 24, 2018

Deploy preview for using-contentful failed.

Built with commit 4cce450639ca40a7ecd8d50c7e9103b3f012e9af

https://app.netlify.com/sites/using-contentful/deploys/5b8081e7b13fb179214dd5a0

@vtenfys
Copy link
Contributor Author

vtenfys commented Aug 24, 2018

Finally got it working locally and on Travis!

@vtenfys vtenfys changed the title [v2] Fix Gatsbygram Cypress tests [v2] Fix Gatsbygram Cypress tests and Windows tests Aug 24, 2018
@vtenfys
Copy link
Contributor Author

vtenfys commented Aug 24, 2018

I tried fixing the AppVeyor problems - the line break issue is solved but now, for whatever reason, it's outputting differently... Again, all tests are passing on my laptop (running Ubuntu, but I can try testing on Windows later since it's dual-boot)

image

@vtenfys vtenfys changed the title [v2] Fix Gatsbygram Cypress tests and Windows tests [v2] [WIP] Fix Gatsbygram Cypress tests and Windows tests Aug 25, 2018
@vtenfys vtenfys changed the title [v2] [WIP] Fix Gatsbygram Cypress tests and Windows tests [v2] Fix Gatsbygram Cypress tests Aug 25, 2018
@vtenfys
Copy link
Contributor Author

vtenfys commented Aug 25, 2018

I've decided to stop work on fixing the Windows tests - after more testing it seems to be a bug in the way Babel handles globs on Windows

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbailey00 ! 🙏

@pieh pieh merged commit 485d1b5 into gatsbyjs:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants