Fix gatsby-link anchor click #7536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have ```javascript <Link to="#hash">Go to section</Link> ``` Clicking it would load / instead of scroll to section
KyleAMathews
force-pushed
the
master
branch
5 times, most recently
from
fc4ca3e to
2116fff
Compare
|
Thanks for opening this @porfirioribeiro 🙏👍 It looks like a fix has now been handled in #8061 so I'm going to close this PR. Please re-open if I've got it wrong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have
Clicking it would load / instead of scroll to section
This happens because pathname in not a empty string anymore but
/because ofwithPrefix