-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gatsby v1-to-v2 guide to include add'l guidance on removal of layouts #6700
Conversation
Deploy preview for using-remark failed. Built with commit c93c841 https://app.netlify.com/sites/using-remark/deploys/5b5771cb792f895e0e21f8de |
Deploy preview for image-processing failed. Built with commit c93c841 https://app.netlify.com/sites/image-processing/deploys/5b5771c9792f895e0e21f8d6 |
Deploy preview for using-postcss-sass failed. Built with commit c93c841 https://app.netlify.com/sites/using-postcss-sass/deploys/5b5771c9792f895e0e21f8d2 |
Deploy preview for using-drupal ready! Built with commit c93c841 |
Deploy preview for gatsbygram ready! Built with commit c93c841 |
Deploy preview for gatsbyjs failed. Built with commit c93c841 https://app.netlify.com/sites/gatsbyjs/deploys/5b5771c8792f895e0e21f8ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Nicely written and I'm sure people will appreciate the clarifications here while upgrading.
Holy buckets, @bw — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
This is an update to the v1-to-v2 guide in the docs, adding more clarity on the design shift from layouts-wrap-pages to pages-wrap-components. It includes a link to the ongoing discussion in #6127.
I also flipped, within that section of the guide, the order of #4 and #5. It seems to me that it's more likely that someone is using props in layouts than using queries. This order roughly prioritizes the tasks for upgrading components by order of likelihood.