Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v2 migration docs about babel configuration #5881

Merged

Conversation

thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented Jun 13, 2018

Summary

Updates v2 migration guide with a section about potential conflicts with root level .babelrc configuration files

  • discussed here here
  • advised on the approach here

@thescientist13 thescientist13 changed the title section for babel and jest update v2 migration docs about babel configuration Jun 13, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 👍

@m-allanson m-allanson merged commit d262eef into gatsbyjs:v2 Jun 13, 2018

[This GitHub comment](https://github.com/facebook/jest/issues/1468#issuecomment-361260279) documents the steps needed to do that.

More information on Gatsby and Babel configuration available [here](https://v2--gatsbyjs.netlify.com/docs/babel/#how-to-use-a-custom-babelrc-file).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-allanson I think we should avoid using temporary link https://v2--gatsbyjs.netlify.com/ in any place, I just closed a similar PR #5870

@jlengstorf
Copy link
Contributor

Hiya @thescientist13! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants