Use Prismjs dependency info from library instead of vendored version #5000
Conversation
|
Deploy preview for using-drupal ready! Built with commit 4dbb56f3f6bb07aafaa703f18d161ce60965dfd3 |
|
Deploy preview for using-drupal ready! Built with commit 27ddff316c4a4d473b294fb366ef9c0dda4f1b3b |
|
Deploy preview for gatsbygram ready! Built with commit 4dbb56f3f6bb07aafaa703f18d161ce60965dfd3 |
|
Deploy preview for gatsbygram ready! Built with commit 27ddff316c4a4d473b294fb366ef9c0dda4f1b3b |
|
Deploy preview for gatsbygram ready! Built with commit 7935568 |
|
Deploy preview for using-drupal ready! Built with commit 7935568 |
|
Couldn't prismjs be peerDependency then? This update still ties prismjs version to gatsby-remark-prismjs. If prismjs would become peerDependency it would be up to user to pick prismjs version and even less maintenance needed for gatsby plugin. (just thinking here) |
|
I don't have an opinion there. As long as we're using prismJS > 1.13.0, whatever version of Prism should be fine. Would peerDependency require the user to install PrismJS explicitly, or would it be installed automatically still? (ie: Would the instructions need to change to |
|
User would have to explicitly install prismjs - we already do this with react helmet plugin ( https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-react-helmet#install ) |
There was a problem hiding this comment.
Yeah let's move to requiring PrismJS as a peerDependency, this is a pattern that's been adopted by other plugins too.
e.g. see https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-styled-components
|
Ok, will do shortly. |
|
Thanks for adding it to devDeps too. I've missed that this would cause issues with tests. Last things from me:
|
Signed-off-by: Rob Bayliss <[email protected]>
|
Ok, think we're all set with the requested changes. Sorry for the commit noise... having some trouble remembering to |
|
Don't worry about the noise. One snapshot is missing update - I guess this change got lost in all the signoff handling, because that test was passing before change to peerDeps. |
Signed-off-by: Rob Bayliss <[email protected]>
KyleAMathews
dismissed
m-allanson’s stale review
prismjs now moved to peerDependencies
|
Oh, and congrats on snagging issue #5000!!! :-D |
Previously it appears to only work for Javascript and HTML gatsbyjs/gatsby#5000
gatsby-remark-prismjshas historically used a vendored copy of PrismJS's language dependencies, because this data wasn't exposed on the PrismJS side. This is no longer the case - as of 1.13.0, language dependency data is exposed incomponents.js. This PR uses the data fromcomponents.jsto load languages, meaning there will be no more maintenance required to stay current with PrismJS changes.Fixes #5001