feat: add eslint loader to webpack config #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
KyleAMathews
suggested changes
Apr 9, 2018
| graphql: true, | ||
| }, | ||
| extends: `react-app`, | ||
| plugins: [`graphql`], |
There was a problem hiding this comment.
You need to connect this too our GraphQL schema still right?
There was a problem hiding this comment.
The schema is in the store so should be easy to pop into here:
There was a problem hiding this comment.
ah good catch! thank you! 🙏
|
BTW, just wanted to double-check this works in the overlay? |
|
Oh, I need to check overlay too, will do that! 👍 |
kkemple
force-pushed
the
topics/add-eslint-loader
branch
from
e2477ca to
62f5e0e
Compare
|
I've integrated the schema into eslint config and ensured proper overlay behavior, i.e. it shows overlay for errors but not warnings Let me know if I need to do anything else! |
Signed-off-by: Kurtis Kemple <[email protected]>
kkemple
force-pushed
the
topics/add-eslint-loader
branch
from
62f5e0e to
a27c133
Compare
KyleAMathews
approved these changes
Apr 14, 2018
|
Thanks! |
This was referenced Apr 16, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds eslint-loader to webpack config using
eslint-config-react-appandeslint-plugin-graphql. This closes #1287 and closes #1564.Some notes:
This uses config very similar to what
Create React Appuses except it adds GraphQL support via theeslint-plugin-graphqlrules.I used CRA as a guideline for dependency placement in package.json. I know @KyleAMathews mentioned making eslint a peer dep in #1564.
I would love some feedback and it would be great to get this in a couple projects for confirmation!