Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][www] Replace main navigation item "Community" with "Plugins" #4472

Merged
merged 10 commits into from
Mar 13, 2018
Merged

[WIP][www] Replace main navigation item "Community" with "Plugins" #4472

merged 10 commits into from
Mar 13, 2018

Conversation

fk
Copy link
Contributor

@fk fk commented Mar 11, 2018

  • Add "Plugins" item to mobile navigation.
  • Replace main navigation item "Community" with "Plugins".
  • Move "Community" page to "Docs" and redirect from /community to /docs/community/.

Ref. #4394

@ghost ghost assigned fk Mar 11, 2018
@ghost ghost added the review label Mar 11, 2018
@gatsbybot
Copy link
Collaborator

gatsbybot commented Mar 11, 2018 •
edited
Loading

Deploy preview for gatsbygram ready!

Built with commit c62327e

https://deploy-preview-4472--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Mar 11, 2018 •
edited
Loading

Deploy preview for using-drupal ready!

Built with commit c62327e

https://deploy-preview-4472--using-drupal.netlify.com

@fk fk mentioned this pull request Mar 13, 2018
Closed
16 tasks
@fk
Copy link
Contributor Author

fk commented Mar 13, 2018

Icon alternatives:

36557742-68f30e44-1809-11e8-9f00-60e7246f8731

Quoting myself from #3456 (comment)

The two above the "magic wand" icon a) pick up the quite common "puzzle pieces" metaphor for "Plugins", b) show data flowing through those plugins (and/or "Transformers"), all within the Gatsby monogram/"G" shape. Not super clear, so probably not a way to go.

@KyleAMathews
Copy link
Contributor

Quick review:

  • Move community link to the top "Quick Start" section
  • The mobile nav looks a bit crowded — drop the community link now?

Otherwise looks great! Excited to go public with this :-D

@fk
Copy link
Contributor Author

fk commented Mar 13, 2018

@KyleAMathews Updated! One more thing: "Plugin Library" currently lives at /packages/ and is the only page section where the URL does not match the section title…

@fk
Copy link
Contributor Author

fk commented Mar 13, 2018

Probably should fix this 😅

image

@fk
Copy link
Contributor Author

fk commented Mar 13, 2018

GTG!

@KyleAMathews KyleAMathews merged commit 8454195 into gatsbyjs:master Mar 13, 2018
@ghost ghost removed the review label Mar 13, 2018
@KyleAMathews
Copy link
Contributor

🎉

@fk fk deleted the topics/www-navigation-add-plugins branch June 28, 2018 01:48
@KyleAMathews KyleAMathews mentioned this pull request Jul 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fk fk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fk @gatsbybot @KyleAMathews