Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to ESM compatible version of CTF library #39178

Merged
merged 12 commits into from
Dec 13, 2024
Merged

feat: update to ESM compatible version of CTF library #39178

merged 12 commits into from
Dec 13, 2024

Conversation

axe312ger
Copy link
Collaborator

No description provided.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 5, 2024
@serhalp serhalp added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change topic: source-contentful Related to Gatsby's integration with Contentful labels Dec 11, 2024
@serhalp
Copy link
Contributor

serhalp commented Dec 11, 2024

Thanks @axe312ger!

It looks like the tests are failing, e.g.

/home/circleci/project/packages/gatsby-source-contentful/src/__tests__/fetch-network-errors.js

  ● fetch-retry › request should fail after to many retries

    expect(received).toEqual(expected) // deep equality

    Expected: StringContaining "Fetching contentful data failed: ERR_BAD_RESPONSE 500 MockedContentfulError"
    Received: "Fetching contentful data failed: ERR_BAD_RESPONSE 500 500 MockedContentfulError Mocked message of Contentful error··
    ---
    Request ID: 123abc·
    Attempts: 3·
    ---

@axe312ger
Copy link
Collaborator Author

Yes, thanks. Just on it! :)

@axe312ger
Copy link
Collaborator Author

Had to do 772d895 and 8d93859 to make CI happy. Please extract, remove, ignore, merge as you like @Gatsby Team

pieh
pieh requested changes Dec 12, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
axe312ger and others added 4 commits December 12, 2024 11:36
@axe312ger @pieh
Update .circleci/config.yml
e424fee 
Co-authored-by: Michal Piechowiak <[email protected]>
@axe312ger @pieh
Update .circleci/config.yml
761bb63 
Co-authored-by: Michal Piechowiak <[email protected]>
@pieh
test: adjust adapter e2e tests (#39182)
d54bde3 
* debug: adapter e2e tests

* Update netlify.mjs

* Update netlify.mjs

* Update netlify.mjs

* Update remote-file.cy.ts

* Update netlify.mjs
@pieh
Revert "fix: ensure we pass the corrent data to variable declaration …
fd84fa4 
…check"

This reverts commit 772d895.
@pieh pieh merged commit 3ccd1d8 into master Dec 13, 2024
38 checks passed
@pieh pieh deleted the build/contentful-v11 branch December 13, 2024 09:57
pieh pushed a commit that referenced this pull request Dec 13, 2024
@axe312ger @pieh
feat: update to ESM compatible version of CTF library (#39178)
8293b82 
* feat: update to ESM compatible version of CTF library and support latest rich text types

* build: clean up lock file

* fix: ensure we pass the corrent data to variable declaration check

* build: redo yarn.lock based on current master

* fix: make sure tests pass with new ctf client

* build: upgrade node version of circle ci e2e tests to match minimum engine version

* build: dedupe yarn.lock

* build: ensure we don't have duplicate versions of @contentful/rich-text-types

* Update .circleci/config.yml

Co-authored-by: Michal Piechowiak <[email protected]>

* Update .circleci/config.yml

Co-authored-by: Michal Piechowiak <[email protected]>

* test: adjust adapter e2e tests (#39182)

* debug: adapter e2e tests

* Update netlify.mjs

* Update netlify.mjs

* Update netlify.mjs

* Update remote-file.cy.ts

* Update netlify.mjs

* Revert "fix: ensure we pass the corrent data to variable declaration check"

This reverts commit 772d895.

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 3ccd1d8)
@gatsbybot gatsbybot mentioned this pull request Dec 13, 2024
Merged
pieh pushed a commit that referenced this pull request Dec 13, 2024
@gatsbybot @axe312ger
feat: update to ESM compatible version of CTF library (#39178) (#39185)
dcfadbe 
* feat: update to ESM compatible version of CTF library and support latest rich text types

* build: clean up lock file

* fix: ensure we pass the corrent data to variable declaration check

* build: redo yarn.lock based on current master

* fix: make sure tests pass with new ctf client

* build: upgrade node version of circle ci e2e tests to match minimum engine version

* build: dedupe yarn.lock

* build: ensure we don't have duplicate versions of @contentful/rich-text-types

* Update .circleci/config.yml

Co-authored-by: Michal Piechowiak <[email protected]>

* Update .circleci/config.yml

Co-authored-by: Michal Piechowiak <[email protected]>

* test: adjust adapter e2e tests (#39182)

* debug: adapter e2e tests

* Update netlify.mjs

* Update netlify.mjs

* Update netlify.mjs

* Update remote-file.cy.ts

* Update netlify.mjs

* Revert "fix: ensure we pass the corrent data to variable declaration check"

This reverts commit 772d895.

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 3ccd1d8)

Co-authored-by: Benedikt Rötsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer topic: source-contentful Related to Gatsby's integration with Contentful type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @serhalp @pieh