Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Restore asset, path prefix for file-loader handled files #38764

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

pastepi
Copy link

@pastepi pastepi commented Dec 16, 2023

Description

This PR applies a fix from gatsby@5 (#37429) that I noticed was forgotten/skipped/not backported to gatsby@4 for some reason.
Besides the cherry-picked commit I had to add missing publicPath var, as it wasn't used in v4 in webpack-utils.

Documentation

N/A

Tests

Cherry-picked pathPrefix tests from gatsby@5.

Related Issues

Fixes #37427 for gatsby v4

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 16, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 18, 2023
@pieh pieh changed the title fix(gatsby): Backport from gatsby@5 - Restore asset, path prefix for file-loader handled files fix(gatsby): Restore asset, path prefix for file-loader handled files Dec 18, 2023
@pieh pieh merged commit 5ea513c into gatsbyjs:release/4.25 Dec 19, 2023
26 of 35 checks passed
@pieh
Copy link
Contributor

pieh commented Dec 19, 2023

Released in [email protected]. Thanks!

@pastepi pastepi deleted the fix/v4-path-and-asset-prefix branch December 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants