-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): clear and close lmdb after each test suite #36343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 9, 2022
pieh
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 10, 2022
pieh
changed the title
just checking flaky windows tests
fix(test): clear and close lmdb after each test suite
Aug 10, 2022
LekoArts
approved these changes
Aug 11, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Dec 26, 2022
This was referenced Dec 26, 2022
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First problem - our test suites are not really isolated when it comes to lmdb - once lmdb is opened in a process it will remain opened until closed.
Second problem -
global
is resetted between test suites/files - that means neither we or lmdb internally can use anything "global" like to prevent opening new dbs in new test suites tespite those dbs being in fact already openend.This PR does few things:
global
object for the test suite that might have been mutated - in our case references to open lmdb dbs)global
tracking forcache-lmdb
(we already use it for datastore)Related Issues