feat(gatby-script): Shim requestIdleCallback #35611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
marvinjude
force-pushed
the
shim-request-idle-callback
branch
2 times, most recently
from
10538ca to
84ff088
Compare
LekoArts
added
topic: DX
marvinjude
force-pushed
the
shim-request-idle-callback
branch
from
ab5cef2 to
e55e787
Compare
tyhopp
suggested changes
May 16, 2022
There was a problem hiding this comment.
Few changes, please make sure the tests pass locally and in CI.
You can update the outdated load plugin snapshots with yarn jest /Users/<YOUR_USER>/Developer/gatsby/gatsby/packages/gatsby/src/bootstrap/load-plugins/__tests__ --updateSnapshot so that unit tests pass and you can see these e2e tests pass in CI.
e2e-tests/development-runtime/cypress/integration/gatsby-script/shimmed-req-idle-callback.js
Outdated
Show resolved
Hide resolved
e2e-tests/development-runtime/cypress/integration/gatsby-script/shimmed-req-idle-callback.js
Outdated
Show resolved
Hide resolved
e2e-tests/development-runtime/cypress/integration/gatsby-script/shimmed-req-idle-callback.js
Outdated
Show resolved
Hide resolved
marvinjude
force-pushed
the
shim-request-idle-callback
branch
from
3582825 to
ba5591c
Compare
Snapshot updates are now on feat-script-component |
12 tasks
tyhopp
force-pushed
the
shim-request-idle-callback
branch
from
83fb9f3 to
f5d616a
Compare
tyhopp
added
type: feature or enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shim requestIdleCallback, cancelIdleCallback
[sc-48843]